Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the Dyno resolver have exposed some bugs that once again break hovering over
string
with the resolver enabled. This PR fixes a number of minor issues that cause crashes. The changes are as follows:[?D]
now resolves to a generic array type as opposed to 'Unknown'.null
actual types, but this can happen sometimes (e.g., when the call site allows for the possibility ofout
-formals being matched with the actual). This change adjusts the code to handle that by simply not attempting to resolve builtins in that case (none of the haveout
formals, so this is sound).Reviewed by @dlongnecke-cray -- thanks!
Testing